nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
133 stars 21 forks source link

fix: add aria-label to NcSelect #1148

Closed enjeck closed 1 week ago

enjeck commented 1 week ago

It's good for accessibility if the NcSelect component has an aria-label. Plus, this fixes the error in the console:

Console Error vue.runtime.esm.js:4625 [Vue warn]: [NcSelect] An `inputLabel` or `ariaLabelCombobox` should be set. If an external label is used, `labelOutside` should be set to `true`. found in ---> at src/shared/components/ncTable/sections/CustomTable.vue at src/shared/components/ncTable/NcTable.vue at src/modules/main/partials/TableView.vue at src/modules/main/sections/DataTable.vue at src/modules/main/sections/TableWrapper.vue at src/pages/Context.vue at src/App.vue
juliushaertl commented 1 week ago

Please also try to fill relevant info in the github sidebar and request reviewers :)

juliushaertl commented 1 week ago

I guess we also want a backport? :)

enjeck commented 1 week ago

/backport to stable0.7

backportbot[bot] commented 1 week ago

The backport to stable0.7 failed. Please do this backport manually.

# Switch to the target branch and update it
git checkout stable0.7
git pull origin stable0.7

# Create the new backport branch
git checkout -b backport/1148/stable0.7

# Cherry pick the change from the commit sha1 of the change against the default branch
# This might cause conflicts, resolve them
git cherry-pick 1c8d88f5

# Push the cherry pick commit to the remote repository and open a pull request
git push origin backport/1148/stable0.7

Error: No changes found in backport branch


Learn more about backports at https://docs.nextcloud.com/server/stable/go.php?to=developer-backports.

enjeck commented 1 week ago

We don't have pagination in stable 0.7, so can't backport this