search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
142 stars 24 forks source link

OpenAPI annotation for createRowInTable is likely wrong #1157

Closed marcelklehr closed 3 months ago

marcelklehr commented 3 months ago

Steps to reproduce

See https://github.com/nextcloud/tables/blob/main/lib/Controller/Api1Controller.php#L1100

Expected behavior

The code seems to expect

/** @var array<int,mixed> */

Actual behavior

Actually declared is

/** @var array{columnId: int, value: mixed} */

Tables app version

main

Browser

No response

Client operating system

No response

Operating system

No response

Web server

None

PHP engine version

None

Database

None

Additional info

No response

blizzz commented 3 months ago

<mixed, array{'columnId': int, 'value': mixed}> to be more precise.

No, that's later :D