enh(API): add OCS API to create rows

nextcloud / tables

🍱 Nextcloud tables app

https://apps.nextcloud.com/apps/tables

GNU Affero General Public License v3.0

133 stars 21 forks source link

enh(API): add OCS API to create rows #1161

Closed blizzz closed 2 days ago

blizzz commented 1 week ago

solves #1105

also features :sparkles: completed and flexible PermissionMiddleware :sparkles: integration tests of new endpoint against both tables and views, owners and sharees, negative tests :sparkles: the advertised new OCS endpoint for creating rows :sparkles: helper model to avoid a loose array with set or not set keys flying around :sparkles: simple conversion helper to translate stringy node types to ints and other way around

Open question: should I create endpoints for all other row-related methods as well? Would make sense, this feels incomplete. Can do a follow up as well of course.

blizzz commented 1 week ago

Just realized, there is a good number of added lines. But worry not:

~37% are OpenAPI specs
~37% are Integration tests
<30% is production code (and even there are lotta comments)

blizzz commented 4 days ago

One set of failing tests were about gracefullness – fixed.

The other, because in 26 there is no NoAdminRequired attribute, only the annotation. Fixed the compatibility thing by adding it. We may consider nevertheless to drop 26 from 0.8.

blizzz commented 3 days ago

btw,

Open question: should I create endpoints for all other row-related methods as well? Would make sense, this feels incomplete. Can do a follow up as well of course.

would only do as follow up, if only to not make this PR bigger

juliushaertl commented 2 days ago

Open question: should I create endpoints for all other row-related methods as well? Would make sense, this feels incomplete. Can do a follow up as well of course.

would only do as follow up, if only to not make this PR bigger

Yes, makes sense to line up for implementation I'd say, but let's keep this separate.