search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
148 stars 23 forks source link

fix: ensure default values show as filled #1176

Closed enjeck closed 3 months ago

enjeck commented 4 months ago

fixes #993

elzody commented 4 months ago

Seems reasonable, just a weird Cypress error. I am assuming it is related since it's affecting the column-number.cy.js test, but have not looked into it.

juliusknorr commented 4 months ago

I am wondering if instead of filling the default value then we should rather use the placeholder attribute and andjudt the check to allow empty fields for values that have a default? That way a default value would also adapt if changed on the table level.

enjeck commented 4 months ago

I am wondering if instead of filling the default value then we should rather use the placeholder attribute and andjudt the check to allow empty fields for values that have a default? That way a default value would also adapt if changed on the table level.

I just noticed that this problem also affects other column types, not just the number column. Would look into making this approach more generic

juliusknorr commented 3 months ago

Don't be too hesitant to click the merge button if it is green 😁