search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
148 stars 23 forks source link

feat(Contexts): enable nav bar display logic #1193

Open blizzz opened 4 months ago

blizzz commented 4 months ago

contributes to #1177

It was temporarily disabled and shown by default as we did not have web UI controls to configure it.

enjeck commented 3 months ago

Let me block the merge just to be sure this doesn't get lost from the initial post

⚠️ merge only with the frontend tasks as laid out in #1177 (comment)

Yeah, I'm looking into the frontend parts :D

juliusknorr commented 3 months ago

Great, thanks :)

enjeck commented 2 months ago

It seems there's no way for an owner to modify their navigation entry if there are no shares? Creating an application without shares means there's no navigation entry, and no way to change it. @blizzz

blizzz commented 2 months ago

It seems there's no way for an owner to modify their navigation entry if there are no shares? Creating an application without shares means there's no navigation entry, and no way to change it. @blizzz

This is accurate. We bound the nav bar display state to sharing. Also the share id is part of the primary key.

I do see it is reasonable to have this setting for non-shared applications, but spontaneously a quick solution that is not too terrible does not come to my mind. Is it a blocker?

enjeck commented 2 months ago

It seems there's no way for an owner to modify their navigation entry if there are no shares? Creating an application without shares means there's no navigation entry, and no way to change it. @blizzz

This is accurate. We bound the nav bar display state to sharing. Also the share id is part of the primary key.

I do see it is reasonable to have this setting for non-shared applications, but spontaneously a quick solution that is not too terrible does not come to my mind. Is it a blocker?

Maybe not a blocker, but still inconvenient and not very user-friendly. The UI right now doesn't look great, and I can't seem to fix it due to this: https://github.com/nextcloud/tables/pull/1295

blizzz commented 2 months ago

It seems there's no way for an owner to modify their navigation entry if there are no shares? Creating an application without shares means there's no navigation entry, and no way to change it. @blizzz

This is accurate. We bound the nav bar display state to sharing. Also the share id is part of the primary key. I do see it is reasonable to have this setting for non-shared applications, but spontaneously a quick solution that is not too terrible does not come to my mind. Is it a blocker?

Maybe not a blocker, but still inconvenient and not very user-friendly. The UI right now doesn't look great, and I can't seem to fix it due to this: #1295

Yup, I am with you there. Need to think about a good strategy.