search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
148 stars 23 forks source link

fix(View): column might be saved as null #1196

Closed blizzz closed 3 months ago

blizzz commented 4 months ago

fixes #1188

TODO: in a follow up PR(s): prevent save in frontend, and repair step to clean the database from such entries.

blizzz commented 4 months ago

/backport to stable0.7

blizzz commented 4 months ago

@enjeck i see, it is the only filter there

enjeck commented 4 months ago

Maybe we shouldn't create the view at all in such cases

blizzz commented 4 months ago

Maybe we shouldn't create the view at all in such cases

Generally yes, but also too late, they are already there. So need this anyway. I improve.

blizzz commented 4 months ago

@enjeck please check with latest (fixup) commit. It seems it has the nice benefit that the bad filters will also not be stored anymore. A bit more expensive though, but this is temporarily until we have cleaned up stuff in the DB.

enjeck commented 4 months ago

@enjeck please check with latest (fixup) commit. It seems it has the nice benefit that the bad filters will also not be stored anymore. A bit more expensive though, but this is temporarily until we have cleaned up stuff in the DB.

Works for me! Thanks!

blizzz commented 4 months ago

@enjeck please check with latest (fixup) commit. It seems it has the nice benefit that the bad filters will also not be stored anymore. A bit more expensive though, but this is temporarily until we have cleaned up stuff in the DB.

Works for me! Thanks!

Thanks! Squashed.