nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
143 stars 24 forks source link

fix(files): align icon to center #1219

Closed JuliaKirschenheuter closed 2 months ago

JuliaKirschenheuter commented 2 months ago

Fixes https://github.com/nextcloud/tables/issues/1214

Before After
Screenshot from 2024-07-18 11-15-11 Screenshot from 2024-07-26 10-48-10 ------------- ---------------------------------------------------------------
Screenshot from 2024-07-18 11-15-31 Screenshot from 2024-07-26 10-47-57 ------------- ---------------------------------------------------------------
JuliaKirschenheuter commented 2 months ago

thanks @enjeck!

I think there should be more space between the Title input field and the "Description" label in the Create/Edit table modal

I haven't seen it in requirement list

juliushaertl commented 2 months ago

thanks @enjeck!

I think there should be more space between the Title input field and the "Description" label in the Create/Edit table modal

I haven't seen it in requirement list

Would still be nice for general polishing to make things look well aligned but we can probably tackle that when migrating to NcDialog, as a separate issue or right away in here, however you prefer @JuliaKirschenheuter

JuliaKirschenheuter commented 2 months ago

for sure i can make more space between the Title input field and the "Description" label! @enjeck should we probably use nctextfield instead custom input field?

enjeck commented 2 months ago

nctextfield

From the docs here https://nextcloud-vue-components.netlify.app/#/Components/NcFields?id=nctextfield, we can't use it? Or maybe I misunderstand.

Also, if we want to change it here, would be nice to change it everywhere else for consistency

JuliaKirschenheuter commented 2 months ago

From the docs here https://nextcloud-vue-components.netlify.app/#/Components/NcFields?id=nctextfield, we can't use it? Or maybe I misunderstand.

No sure if i understood you correct, i mean something like this:

Screenshot from 2024-07-24 18-54-32

instead of:

Screenshot from 2024-07-24 18-56-15

juliushaertl commented 2 months ago

nctextfield

From the docs here nextcloud-vue-components.netlify.app#/Components/NcFields?id=nctextfield, we can't use it? Or maybe I misunderstand.

Also, if we want to change it here, would be nice to change it everywhere else for consistency

Probably the docs are a bit confusing, this message only referrs to NcInputField, NcTextField is fine to be used (scroll further down for the actual docs of that)

Screenshot 2024-07-25 at 16 03 51
JuliaKirschenheuter commented 2 months ago

I think there should be more space between the Title input field and the "Description" label in the Create/Edit table

done ;)

github-actions[bot] commented 1 month ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)