search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
143 stars 24 forks source link

Migrate `NcModal` to `NcDialog` #1239

Closed JuliaKirschenheuter closed 1 month ago

JuliaKirschenheuter commented 2 months ago

Fixes https://github.com/nextcloud/tables/issues/1213

Reviewers: please test FileActionImport.vue dialog, because i was not able to see it in UI

Before After
Screenshot from 2024-07-25 18-42-30 Screenshot from 2024-07-25 18-46-24 ------------- ---------------------------------------------------------------
Screenshot from 2024-07-25 18-43-03 Screenshot from 2024-07-25 18-46-04 ------------- ---------------------------------------------------------------
Screenshot from 2024-07-25 18-43-56 Screenshot from 2024-07-25 19-11-04
juliushaertl commented 1 month ago

Took the liberty to rebase and push a small adjustment for the cypress selectors that read the heading of the modals so we can get this in :)