nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
148 stars 23 forks source link

can't save edit of a table view when meta data are activated #1364

Open koebi80 opened 1 month ago

koebi80 commented 1 month ago

Steps to reproduce

  1. edit view
  2. activate a meta data colum
  3. press save

Expected behavior

After press the 'save' button the table view is saved and then return to the view

Actual behavior

After pressing 'save' button two error messages apears:

Bildschirmfoto 2024-09-17 um 12 21 29

"Ansicht konnte nicht aktualisiert werden" = "View could not be updated" "Ansicht konnte nicht aktualisiert werden. Unbekannter Fehler" = "View could not be updated. Unknown error"

I found the following entrie in the NextCloud Server log:

[tables] Warnung: An invalid request occurred: Invalid column ID provided PUT /index.php/apps/tables/view/22 von 65.18.167.149 von Tinu um 17.09.2024, 12:21:25

{"reqId":"SkavvQeURlhA0glGAGIx","level":2,"time":"2024-09-17T10:21:25+00:00","remoteAddr":"65.18.167.149","user":"Tinu","app":"tables","method":"PUT","url":"/index.php/apps/tables/view/22","message":"An invalid request occurred: Invalid column ID provided","userAgent":"Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:130.0) Gecko/20100101 Firefox/130.0","version":"29.0.6.1","exception":{"Exception":"InvalidArgumentException","Message":"Invalid column ID provided","Code":0,"Trace":[{"file":"/var/www/html/custom_apps/tables/lib/Controller/ViewController.php","line":94,"function":"update","class":"OCA\\Tables\\Service\\ViewService","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/custom_apps/tables/lib/Controller/Errors.php","line":22,"function":"OCA\\Tables\\Controller\\{closure}","class":"OCA\\Tables\\Controller\\ViewController","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/custom_apps/tables/lib/Controller/ViewController.php","line":93,"function":"handleError","class":"OCA\\Tables\\Controller\\ViewController","type":"->","args":[["Closure"]]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":232,"function":"update","class":"OCA\\Tables\\Controller\\ViewController","type":"->","args":["*** sensitive parameters replaced ***"]},{"file":"/var/www/html/lib/private/AppFramework/Http/Dispatcher.php","line":138,"function":"executeController","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Tables\\Controller\\ViewController"],"update"]},{"file":"/var/www/html/lib/private/AppFramework/App.php","line":184,"function":"dispatch","class":"OC\\AppFramework\\Http\\Dispatcher","type":"->","args":[["OCA\\Tables\\Controller\\ViewController"],"update"]},{"file":"/var/www/html/lib/private/Route/Router.php","line":331,"function":"main","class":"OC\\AppFramework\\App","type":"::","args":["OCA\\Tables\\Controller\\ViewController","update",["OC\\AppFramework\\DependencyInjection\\DIContainer"],["22","tables.view.update"]]},{"file":"/var/www/html/lib/base.php","line":1058,"function":"match","class":"OC\\Route\\Router","type":"->","args":["/apps/tables/view/22"]},{"file":"/var/www/html/index.php","line":49,"function":"handleRequest","class":"OC","type":"::","args":[]}],"File":"/var/www/html/custom_apps/tables/lib/Service/ViewService.php","Line":275,"message":"An invalid request occurred: Invalid column ID provided","exception":[],"CustomMessage":"An invalid request occurred: Invalid column ID provided"},"id":"66e95a272e3fa"}

Tables app version

0.8.0

Browser

Firefox 130

Client operating system

MacOS Catalina

Operating system

No response

Web server

None

PHP engine version

None

Database

None

Additional info

Views that had meta data enabled before the update were displayed correctly.

If no meta data is activated before saving the view, the view is saved normally.

In the “ocs api viewer” I saw that the ID of the column had negative values for views that had metadata activated before the update to 0.8.0. Maybe this is the problem.

miaddadbin commented 1 month ago

I have the same problem too.

enjeck commented 1 month ago

Maybe similar to https://github.com/nextcloud/tables/issues/694

koebi80 commented 1 month ago

I don't think its similar to https://github.com/nextcloud/tables/issues/694. It's an other bug. The problem discribed at issue https://github.com/nextcloud/tables/issues/694 works in newer versions.

Jerome-Herbinet commented 1 month ago

Same for me with last Tables release on NC 28, 29 and 30.

Jerome-Herbinet commented 1 month ago

@enjeck @juliushaertl any idea of the problem origin ?

enjeck commented 1 month ago

@enjeck @juliushaertl any idea of the problem origin ?

@Jerome-Herbinet Not sure yet. I'll look into it. It might be helpful to look at the changes at https://github.com/nextcloud/tables/pull/1002