search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
148 stars 23 forks source link

enh: Use table id for events #808

Closed enjeck closed 9 months ago

enjeck commented 9 months ago

As part of https://github.com/nextcloud/tables/issues/807. We pass table ids around, for use later to support multiple table instances

enjeck commented 9 months ago

The reason that I'm passing the table ids around is so that they can be used when emitting events. Currently, modals (such as CreateColumn.vue need to know exactly what Table to target, and this is gotten from activeElement stored in the global store. So by passing the table ids around like I've done, we can always specify an active Table and it will work properly, even when there are multiple tables on screen.

We're trying to make NcTable independent, so that it may be moved into the component library someday. So passing the table id as prop in NcTable might jeopardize this.

Not sure if there's a better way (that I understand) to do this.

github-actions[bot] commented 9 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!