Contexts in left navigation sidebar, edit and create modal

nextcloud / tables

🍱 Nextcloud tables app

https://apps.nextcloud.com/apps/tables

GNU Affero General Public License v3.0

148 stars 23 forks source link

Contexts in left navigation sidebar, edit and create modal #844

Closed enjeck closed 8 months ago

enjeck commented 9 months ago

This PR lists contexts in the tables left navigation bar, adds routes and adds create/edit modal

Fixes https://github.com/nextcloud/tables/issues/908 and https://github.com/nextcloud/tables/issues/896 and https://github.com/nextcloud/tables/issues/864

enjeck commented 9 months ago

This is still a work in progress.

Todo

[x] Discuss about what to do about sidebars e.g Sharing. Will these be needed for Contexts (https://github.com/nextcloud/tables/issues/311) or not?
[x] Think about Table/View headers, which are sticky when we scroll. This stickiness isn't ideal when there are multiple elements on a page

juliusknorr commented 9 months ago

Gave this a quick smoke test and seems to work quite well already (also with sticky headers of tables).

github-actions[bot] commented 8 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

enjeck commented 8 months ago

@juliushaertl @elzody Here's my progress so far towards to https://github.com/nextcloud/tables/issues/908 and https://github.com/nextcloud/tables/issues/896 and https://github.com/nextcloud/tables/issues/864. Mostly works, but still needs some minor fixes that I have highlighted in the code as TODOs. Not sure if it'll be confusing for @elzody to pick up some of these TODOs. Or if it's less confusing to pick up another subtask at https://github.com/nextcloud/tables/issues/311

juliusknorr commented 8 months ago

Thanks I'll have a first look tomorrow, I discussed with @elzody ealier that she can look into the icon picker which should go into the modal but can probably be worked on without conflicting with ongoing work too much.

We can further align then tomorrow