feat: implement direct file upload

luka-nextcloud commented 9 months ago

Resolve: #833
Description: Ability to import table with direct file upload.

demo (2).webm

juliusknorr commented 9 months ago

@nextcloud/designers Maybe you can check this one and suggest how we should layout the different upload buttons?

nimishavijay commented 9 months ago

This is a super cool feature! :) General flow looks good! Some comments:

[x] Agreed with @enjeck that the buttons can be named "Upload from device" and "Select from Files" :)
[x] The placement of the buttons can also be improved. The text fields next to the buttons can be removed, the buttons can be on the same row and selected file name can be above the buttons
[x] In the "Create missing columns" section, the explanation text is cut off. It should wrap around, or can even be removed.
[x] The "Information" section currently has a lot of text, some of it can be removed (for example, the "The possible importing..." point seems very technical, would it cause any confusion if it was not there?) and some of it can be inserted in relevant places

So the end result will look something like this

[x] The text on the loading screen can also be reduced if it is not critical
[x] Instead we can show the name of the file (ellipsised if it is too long)

[x] For the result screen, there can be an icon on the left of the heading indicating if there are any errors. If there are no errors, then it can be a checkmark and if there are errors it can be a warning
[x] If there no errors, the last 2 rows can be hidden
[x] If there are errors, it could be indicated by an icon or emoji

✅ Imported from n26_transactions.csv

Found columns        4
Matching columns     0
Created columns      4
Inserted rows        0

⚠️ Imported from n26_transactions.csv

Found columns          4
Matching columns       0
Created columns        4
Inserted rows          0
Value parsing errors   1 ⚠️ 
Row creation errors    1 ⚠️

What do you think? :)

luka-nextcloud commented 8 months ago

demo (3).webm

juliusknorr commented 8 months ago

@blizzz Regarding your row errors mentioned in https://github.com/nextcloud/tables/pull/845#pullrequestreview-1883456697 any chance you have a copy of the file you tried? I could not reproduce that in any way

nextcloud / tables

feat: implement direct file upload #845