nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
148 stars 23 forks source link

feat: Add backend for table archive and favorite flag #865

Closed juliusknorr closed 8 months ago

juliusknorr commented 9 months ago

Resolves #469

juliusknorr commented 9 months ago

@elzody I pushed a few more individual commits here

juliusknorr commented 8 months ago

@blizzz A quick backend review would already be appreciated :)

juliusknorr commented 8 months ago

@elzody I pushed one more fix to also expose the favorite flag on views when they are returned through the API.

juliusknorr commented 8 months ago

Tested what is already there and works like a charm :)

Maybe you can rebase with your next push to latest main branch to resolve the conflict with the merge of #878

enjeck commented 8 months ago

This is really cool :sunglasses:

Not a big deal, but it'll be nice if we eventually indent the views in Archived tables sidebar, so that it's obvious they're part of a specific table:

Here, "view" is a view of "ToDo list", but it's not obvious due to lack of indent: image

juliusknorr commented 8 months ago

Good catch @enjeck

I'll merge this for now and file follow up tasks for the open items

enjeck commented 8 months ago

@juliushaertl Not sure if it's important or not, but I find it weird that the occ command tables:update now has the option --archived, but the title argument is still required. So that means if I wanna archive a table, I'm forced to change the title too?