nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
148 stars 23 forks source link

Extract selection option labels for Analytics #877

Closed Rello closed 4 months ago

Rello commented 8 months ago
enjeck commented 7 months ago

@Rello Hi! Are you still working on this?

Rello commented 4 months ago

Hi @juliushaertl you think we can merge this? tests look ok to me if I can judge them correctly?

blizzz commented 4 months ago

I am afraid this has potential to be breaking potential existing API use cases. I suppose the IDs of the selection can be fetched already (did not double check). Not that the output is much documented.

There is a conflict btw. If we merge, it's better to have the commits squashed.

Rello commented 4 months ago

@blizzz what do you suggest? The idea is nice dynamic and the same for tables & forms (potentially for others). An app can register itself to Analytics. but all the requirements like tests & co are far more that can be achieved by a hobby project.

I think of skipping this and simply ship the datasources for everything with Analytics itself. Kind of double work because local duplication of the API logic might be required in many places. but not impacting other apps

suggestion? also applies to https://github.com/nextcloud/forms/pull/2195

Rello commented 4 months ago

as discussed with @blizzz the Analytics data source was decoupled from the API endpoint to not create breaking changes. Analytics is taking care of any specific logic on its own

blizzz commented 4 months ago

/backport to stable0.7