Closed Rello closed 4 months ago
@Rello Hi! Are you still working on this?
Hi @juliushaertl you think we can merge this? tests look ok to me if I can judge them correctly?
I am afraid this has potential to be breaking potential existing API use cases. I suppose the IDs of the selection can be fetched already (did not double check). Not that the output is much documented.
There is a conflict btw. If we merge, it's better to have the commits squashed.
@blizzz what do you suggest? The idea is nice dynamic and the same for tables & forms (potentially for others). An app can register itself to Analytics. but all the requirements like tests & co are far more that can be achieved by a hobby project.
I think of skipping this and simply ship the datasources for everything with Analytics itself. Kind of double work because local duplication of the API logic might be required in many places. but not impacting other apps
suggestion? also applies to https://github.com/nextcloud/forms/pull/2195
as discussed with @blizzz the Analytics data source was decoupled from the API endpoint to not create breaking changes. Analytics is taking care of any specific logic on its own
/backport to stable0.7
when column type selection is used, the API needs to deliver the labels, and not the internal ids fixes https://github.com/Rello/analytics/issues/385
Using lib/Analytics (and not lib/Datasource) for better readability
Adopting from LegacyRow to Row