Closed blizzz closed 8 months ago
blizzz
commented
8 months ago @enjeck what would be a nice addition is that the appropriate nav bar icon is set active, when being on an application that has an entry there (otherwise going back to tables).
juliusknorr
commented
8 months ago @enjeck what would be a nice addition is that the appropriate nav bar icon is set active, when being on an application that has an entry there (otherwise going back to tables).
I think this is tricky to do on the frontend. We may need a separate backend route to still render the TemplateResponse but then set the active entry on the navigation manager. We can then set an initial state that indicates that we're on an application page and to further adjustments on the frontend side like hiding the navigation by default. Something for a follow up I'd say.
blizzz
commented
8 months ago @enjeck what would be a nice addition is that the appropriate nav bar icon is set active, when being on an application that has an entry there (otherwise going back to tables).
I think this is tricky to do on the frontend. We may need a separate backend route to still render the TemplateResponse but then set the active entry on the navigation manager. We can then set an initial state that indicates that we're on an application page and to further adjustments on the frontend side like hiding the navigation by default. Something for a follow up I'd say.
Ah, I was speculating that such an option exist for fronted, but of course… why would it. There was no similar case before. Follow up is fine +1
solves #863
needs #903 (soft)
wants https://github.com/nextcloud/server/pull/44178Screenshot made with frontend from https://github.com/nextcloud/tables/pull/844. On the content area in the UI we don't render the material icons yet, but the icon is in the nav bar. The icon over the mouse pointer is material design, while the two icons on the very right have fallback icons (default app icon).