search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
143 stars 24 forks source link

fix: properly indent child views of archived tables #909

Closed elzody closed 6 months ago

elzody commented 6 months ago

Fix for issue #892

Added some CSS which will further indent views which are nested in an archived table to make the hierarchy more visible. If there's a better way, definitely let me know :)

Screenshots

Previous ![grafik](https://github.com/nextcloud/tables/assets/23369449/f902e459-33bf-4afa-a3c0-5d36de6aa0f3)
Suggested ![grafik](https://github.com/nextcloud/tables/assets/23369449/dc7afb4d-c847-4075-9d3b-56acd781b096)
jancborchardt commented 6 months ago

@elzody could you add before/after screenshot so a design review is easier? :) Thanks!

elzody commented 6 months ago

@elzody could you add before/after screenshot so a design review is easier? :) Thanks!

No problem, added it now @jancborchardt

juliushaertl commented 6 months ago

Looks good design-wise! Regarding code rather than putting a set number, might be better to use a multiple of the default-grid-baseline variable? (Which is 4px, so 8* that in this case.)

I'd get this in for now. The offset depends on the icon size which is currently also hard coded in the vue library

github-actions[bot] commented 6 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!