search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
143 stars 24 forks source link

fix: views respect sorting #912

Closed enjeck closed 6 months ago

enjeck commented 6 months ago

Fixes https://github.com/nextcloud/tables/issues/911

enjeck commented 6 months ago

A few things to consider:

juliushaertl commented 6 months ago

Thanks for looking into that.

Sorts that are created initially when the view is created are highlighted in the UI as a local setting, and prompts the user Reset local adjustments to erase it. Do we want to make this setting fixed and non-removable?

Yes, i think that makes sense. If custom sortings are applied then we should of course still show the reset button to go back to the view defined sorting.

Some columns like RichText are not sortable. For good UX, we should maybe remove these unsortable options from the list of columns when adding a new sorting rule.

:+1:

github-actions[bot] commented 6 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!