Closed elzody closed 8 months ago
elzody
commented
8 months ago Looks good! I would only suggest that the unfavoriting action for a view still be shown even if it's under a favorited table, in case people want to unfavorite individual views on a favorited table. Then it would also follow a consistent pattern of "everything that's not favorited can be favorited and everything that is favorited can be unfavorited". Does that make sense? :)
Yes, absolutely. Thank you!
github-actions[bot]
commented
7 months ago Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.
We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.
Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6
Thank you for contributing to Nextcloud and we hope to hear from you soon!
Current behavior
If a view is shared (the user is not the owner of the view), the user will have the option to favorite/unfavorite it, but this will not be reflected in the UI (it will not be added/removed from the favorites list).
Suggested behavior
Fix the behavior defined above. Additionally, if a table that contains views is favorited, its views will then not display a favorite/unfavorite button until the table is unfavorited. Any views which are already favorited but are also a part of the table will disappear from the favorite list as an individual view, and instead appear normally under the favorited table. This is done to prevent the view from showing in the favorites list twice.
Recording
https://github.com/nextcloud/tables/assets/23369449/02a5f820-f888-44d7-8ff9-87d1a33a0b9d
TODO