search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
143 stars 24 forks source link

feat: contexts material design icon picker #929

Closed elzody closed 6 months ago

elzody commented 6 months ago

Material design icon picker for Contexts.

Part of #895

juliushaertl commented 6 months ago

Pushed a quick commit to address the icon color and rebased

enjeck commented 6 months ago

@elzody I still don't see the icons in the navigation. Just me? Screenshot from 2024-03-14 14-33-51

elzody commented 6 months ago

@elzody I still don't see the icons in the navigation. Just me?

They show up fine for me, and I'm assuming for @juliushaertl as well? 🤔

image

However, I do notice that when I refresh the page or the contexts are fetched from the backend, it returns null for each property, which is weird. Maybe it's related somehow?

enjeck commented 6 months ago

Here's what I see in the console. I tried restarting my NC server, didn't help:

[Vue warn]: Error in callback for immediate watcher "context.iconName" (Promise/async): "Error: Cannot find module './😀.svg'"

found in

---> <NavigationContextItem> at src/modules/navigation/partials/NavigationContextItem.vue
       <NcAppNavigation>
         <Navigation> at src/modules/navigation/sections/Navigation.vue
           <NcContent>
             <App> at src/App.vue
               <Root>
elzody commented 6 months ago

Here's what I see in the console. I tried restarting my NC server, didn't help:

Looks like it's still trying to pull an emoji from the backend instead of an icon? Interesting, I'll dig through it and see what I can find, then make another fix.

Or maybe, are you still using any applications/contexts from before the icon picker was there and it was emojis? If so, maybe try removing all those and making new ones

github-actions[bot] commented 6 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!