Closed grnd-alt closed 6 months ago
Very nice, two thoughts that might be worth to discuss with @nextcloud/designers :
@grnd-alt I think we're supposed to have this introduction textarea in both the "Create table" and "Edit table" modals. Similarly to the way we have the "Title".
@juliushaertl said:
The editor is not collaborative, so maybe we want to make it read only by default with a button to toggle to edit
Yes, the editor should be read-only when viewing a table. But we don't need a button to toggle edit, imo. We should handle this in the "Edit table" modal instead.
@jancborchardt Thanks for you're input about the way it's done in forms. I've update the screenshots with the new layout. I feel like it could still be improved. It's all quite clustered to the left and the right feels empty. But I don't think we can move the Edit/View/Hide buttons on the same line as the title as they only effect the description editor and not the entire table. I'd propose moving it back to aligning it in the middle (Screenshot Option 2). But if it's better to have it at the left, or you have a different idea I'll happily adapt it.
@jancborchardt I find it very confusing to have an edit button just for the single "description" field. Then a separate button that edits the title in a separate place. Then no way to add a description when creating a table. As a user, I would expect to be able to add a description when creating a table. And to either have a single button to edit everything at once or to be able to inline edit everything. Having a mix feels weird. Maybe it's just me
I find it very confusing to have an edit button just for the single "description" field. Then a separate button that edits the title in a separate place. Then no way to add a description when creating a table. As a user, I would expect to be able to add a description when creating a table. And to either have a single button to edit everything at once or to be able to inline edit everything. Having a mix feels weird. Maybe it's just me
@enjeck yeah you are right – so then should we move the description box editing (and adding) into the modal? And on the tables page we show it read-only, just like we do for the title?
This looks good to me too. Thanks, @grnd-alt
@juliushaertl your change request is still active
Summary
introduce a description editor at the top similar to Files
Screenshots:
Viewing a Table:
Creating a Table:
Editing a Table:
Checklist