nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
148 stars 23 forks source link

feat(import): change column format during import #944

Closed luka-nextcloud closed 3 months ago

luka-nextcloud commented 7 months ago
luka-nextcloud commented 6 months ago

@max-nextcloud @juliushaertl Regarding the column title issue, currently, we do not restrict the duplicate column title. I think we should not allow to create columns with the same title on same table. What do you think?

juliusknorr commented 6 months ago

@max-nextcloud @juliushaertl Regarding the column title issue, currently, we do not restrict the duplicate column title. I think we should not allow to create columns with the same title on same table. What do you think?

I think that would make sense to restrict, maybe we can when importing just add a number to the titles that have duplicates, e.g. having three columns called "title" will result in "title", "title (2)", "title (3)" like we do it in files

jancborchardt commented 6 months ago

Are there any screenshots or quick videos for easier design review, or is all good on that side? :)

luka-nextcloud commented 6 months ago

Are there any screenshots or quick videos for easier design review, or is all good on that side? :)

@jancborchardt Please check the video.

demo.webm

juliusknorr commented 4 months ago

@nextcloud/designers Could you have a look at this?

juliusknorr commented 3 months ago

🏓 @nextcloud/designers

nimishavijay commented 3 months ago

Sorry for the late review!

Overall it looks good! My first impression is that there is a lot of unused whitespace and that some of the wording is not clear, so we can do some changes to help with that: image

What do you think? :)

luka-nextcloud commented 3 months ago

@nimishavijay Thanks for your review. Your review looks good to me.

luka-nextcloud commented 3 months ago

@nimishavijay

nimishavijay commented 3 months ago

"Existing column" --> "Replace existing column" -> I think it should be "Import to existing column".

If that's the correct functionality then this sounds good!

When select "Existing column", users have to select column from select box. It is missing from last video. Please provide suggestion for that function also.

I see. Then:

image

Another behavior is disabling "Create missing columns" will show "Ignore" option at the preview step.

That's perfect. Then it would just be "Import to existing column" and "Ignore column"

Could you also give me suggestions regarding responsiveness?

If all items are on different rows then it should automatically be responsive. Anyway this is a functionality that is unlikely to be widely used on mobile

image

luka-nextcloud commented 3 months ago

@nimishavijay Please check the update:

demo.webm

image

juliusknorr commented 3 months ago

Pushed a quick fix for the stylelint error

juliusknorr commented 3 months ago

I'd say lets get this in and we can address further design feedback or pending points as follow ups. So far this works nicely already.

@luka-nextcloud Could you go over the checkboxes in this issue, check them off if done and file follow up issues for those that need to be done still?