search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
148 stars 23 forks source link

Enhancement/279 pagination for tables ui #972

Closed grnd-alt closed 5 months ago

grnd-alt commented 6 months ago

Design

image

Performance

Loading Time for 3k Rows with pagination

https://github.com/nextcloud/tables/assets/56235737/740f9864-50f6-45f6-9a94-fb48ac33d7fa

3k Rows Without pagination

https://github.com/nextcloud/tables/assets/56235737/f9b98ff4-0f25-4ba5-901e-3416a5d8f2ef

enjeck commented 6 months ago

I realize this is still a draft, but just wondering if this PR adds pagination or virtual scrolling? There seems to be a mismatch between the title and the commit message :sweat_smile:

grnd-alt commented 6 months ago

I realize this is still a draft, but just wondering if this PR adds pagination or virtual scrolling? There seems to be a mismatch between the title and the commit message 😅

Yeah it's because the initial issue planned to implement v-scrolling but that's harder to do on html tables than expected hence we decided to look into pagination

grnd-alt commented 6 months ago

@jancborchardt Updated With New Screenshot

jancborchardt commented 6 months ago

@jancborchardt Updated With New Screenshot

It doesn’t look like it has the drop shadow, but that looks fine to me, as long as the background is opaque color-main-background – so the element is still readable when there is a long table below it. :)