search

nextcloud / tables

🍱 Nextcloud tables app
https://apps.nextcloud.com/apps/tables
GNU Affero General Public License v3.0
143 stars 24 forks source link

fix: Vacation Request template #979

Closed enjeck closed 5 months ago

enjeck commented 5 months ago

Fixes #948

Attempt to fix the vacation template by not using negative indices

enjeck commented 5 months ago

By removing negative indices, I think I fix new tables/views created using the template. But old views stay broken, because the negative indices are still saved. Not sure how to fix this. Suggestion?? @juliushaertl @blizzz

blizzz commented 5 months ago

Questions coming to my mind are also: why did we use hard-coded, negative indexes in first place? I also see traces in lib/Db/ColumnMapper.php, lib/Db/Row2Mapper.php and lib/Db/ColumnTypes/SuperColumnQB.php. Might be they were connected to the template.

By removing negative indices, I think I fix new tables/views created using the template. But old views stay broken, because the negative indices are still saved. Not sure how to fix this. Suggestion?? @juliushaertl @blizzz

Not very familiar with templates… but can we deduct them? Then we can do it in a repair step, reading out the correct values and replacing the hard coded ids. But probably that's a lot of guess work and not reliable either. Can there be actual production tables based on the buggy template? For if not it is best to suggest to recreate that.

github-actions[bot] commented 5 months ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!