nextcloud / talk-android

📱😀 Video & audio calls through Nextcloud on Android
Other
517 stars 224 forks source link

get rid of forked ChatKit #1552

Open mahibi opened 2 years ago

mahibi commented 2 years ago

in the past the fork https://github.com/nextcloud/ChatKit was created from https://github.com/stfalcon-studio/ChatKit The modifications and the useage of https://github.com/nextcloud/ChatKit are too complicated.

The best solution would be to implement the needed designs etc on our own so we are more flexible. Or at least we should use some well maintained lib (possibly switch back to original https://github.com/stfalcon-studio/ChatKit)

provokateurin commented 1 year ago

The upstream ChatKit hasn't been updated in 1.5 years, we should probably not use it and just switch away from ChatKit completely.

tobiasKaminsky commented 1 year ago

Great idea, but which…? I searched a bit, but did not find a good alternative…

provokateurin commented 1 year ago

I think the plan was to build it all on our own, but that is a lot of work...

AndyXheli commented 1 year ago

Would anything from this link help ?

https://android.libhunt.com/chatkit-alternatives

provokateurin commented 1 year ago

All the suggestions are not related to chat ui libraries...

AndyScherzinger commented 1 year ago

None of the libs in the link provide anything related to a chat view 😔

AndyScherzinger commented 1 year ago

@jld3103 yeah, I am unsure if completely building it on our own is worth it or if looking into how to upgrade to their latest version/master would be possible since the lib actually offers some thing we want in their latest version like image or map chat bubbles.

provokateurin commented 1 year ago

Forking the latest version and then building on top of that sounds good. Some initial work to update it, but a lot less work implementing the basic stuff.

AndyScherzinger commented 1 year ago

I quickly talked about it today mentioning this also to @mahibi Issue is that it is also meshed together with the fresco fork I think. I tried it a while ago but failed due to time constraints on my side.

provokateurin commented 1 year ago

I looked at the forked ChatKit and Fresco isn't used as a dependency in it. Not sure why everyone thinks this is the case, maybe it's just used together.

mahibi commented 1 year ago

yes it's just used together. didn't have a closer look now what exactly is related. but regarding fresco: maybe there is the need anyway to get rid of the forked fresco because of https://github.com/nextcloud/talk-android/issues/2376 (@timkrueger wants to work on this next i think..) so maybe we should first try to replace fresco and then chatkit.

timkrueger commented 1 year ago

but regarding fresco: maybe there is the need anyway to get rid of the forked fresco because of #2376 (@timkrueger wants to work on this next i think..) so maybe we should first try to replace fresco and then chatkit.

Yes. I'm currently replace Fresco with coil. By the way I try to centralize some heavily distributed code to load avatar images. But the core is to get rid of Fresco because it blocks the increase of the minSdkVersion.

mahibi commented 1 year ago

once chatkit is replaced/updated we should switch to emoji2 (because newer emojis are not correctly shown atm) https://developer.android.com/jetpack/androidx/releases/emoji2

However only the forked chatKit from nextcloud implemented the usage of emojis...: https://github.com/nextcloud-deps/ChatKit/commit/1cdff9b81861e072ab7ec473532b1bf8714f794c#diff-f740b02064d567b4c1f12acbd1163a07c8a9e6aa296aeb628783514c0693b5c4

AndyScherzinger commented 1 year ago

@mahibi so for emojis then there is no dependency because we could still decide to replace it even in the current forked version of chat kit, no?

mahibi commented 1 year ago

@mahibi so for emojis then there is no dependency because we could still decide to replace it even in the current forked version of chat kit, no?

yes. we can bump to emoji2 in the forked chatkit and in the talk app to avoid the version clash. We should do this when https://github.com/nextcloud/talk-android/pull/2449 is merged..

mahibi commented 2 months ago

just for the record: ChatKit is driving me totally crazy again so +1 to remove it!!

Replacing it with own code using Jetpack Compose would be worth it in my opinion.