Open AndyXheli opened 2 years ago
@andyxheli is the image in both screenshots the same one, since one seems to be a photo from a monitor image and with a different image ratio, no?
Hi @AndyScherzinger what I mean is maybe removing the name of the photo from that chat and making it similar to telegram I'm sorry about that bad photos
Telegram
needs to be aligned with the talk iOS app. there we also have the filename under the photos. on web it's a mouseover tooltip.
if we decide to hide the filename then it would also make sense to move the time onto the photo like telegram does.. the filename would still be visible when opening the photo in fullscreen..
I think this would be a good approach while currently we do not have a dedicated "image-bubble" but a preview one and this approach only works well for images but not for other files like pdfs, so we would need to add a distinction and a specific image bubble I think.
Hey guys here's a screenshot of how it looks when you send photos with big file name. Personally it would be nice to remove the name of the photos from the viewer
@jancborchardt @nimishavijay what do you think? https://github.com/nextcloud/talk-android/issues/2366#issuecomment-1245901961
I like it and agree with @mahibi - if we do it we need to do it i Android and iOS as well as for photos only think.
Agreed, file names for images are usually technical and not useful, so it makes sense to remove it.
As for an "Image bubble" I think it's a good idea. Telegram and WhatsApp have a bubble, and whenever there is an image caption it is a part of the bubble. So if we are planning to have image captions in the future a bubble is certainly the right direction.
Also agreed that the timestamp can be within the image. Note that there is always a half transparent black background with the timestamp text in white (in WhatsApp, Telegram and Signal) so that the timestamp is visible if the image is white.
For other file types, the name is useful but I think it can still be within a bubble and the name ellipsized, so that the size still remains consistent. Similar to WhatsApp and telegram
Ah, I see for the other file types, yes makes sense in case we would have a preview available. Not sure we know that upfront all the time though.
Not implementing it until https://github.com/nextcloud/talk-android/issues/1552 is resolved
I don't know about the overall plan, but #2366 (this issue) says the solution won't be implemented until #1552 is resolved. And #1552 says it won't be done until #2449 is merged.
With #2449 now merged, can we rethink #1552 and, eventually, #2366 (this issue), which I would very much like to see resolved?
Thanks!
Hey I would agree any plans on getting this implemented?
Well, all devs are currently busy with feature, of course contributions are aways welcomed, also for this one. Maybe somebody finds the time when limiting it to image previews for the momentum and how the issue discussion initially started.
I don't know how hard it would take to implement but it sure would be nice.
Here's an in-chat image preview on Nextcloud Android Talk and the corresponding view on Telegram
Talk Telegram
Similar too https://github.com/nextcloud/talk-ios/issues/776