search

nextcloud / talk-android

📱😀 Video & audio calls through Nextcloud on Android
Other
532 stars 239 forks source link

call buttons are shown when they shouldn't ("call buttons were null when trying to disable them") #3843

Open mahibi opened 5 months ago

mahibi commented 5 months ago

Steps to reproduce

open a conversation where the call buttons should be disabled. For example "Note to self".

Expected behaviour

call buttons are disabled

Actual behaviour

call buttons are enabled

Log: "call buttons were null when trying to disable them" conversationVoiceCallMenuItem and conversationVideoMenuItem are null. Handling related to onPrepareOptionsMenu must be improved?

I can imagine that sometimes it works and sometimes not, as there could be a race condition.

Nextcloud Talk app version

19.1.0 Alpha 04 (most likely since ever)

mahibi commented 5 months ago

should be done when capabilities are loaded from DB (offline support), so closing for now

mahibi commented 1 week ago

still happening with 20.0.1 Also: for federated rooms, the call buttons disappear after 30 sec because "call buttons were null..."

mahibi commented 1 week ago

seems to be explained by the if (this::spreedCapabilities.isInitialized) {.... behavior which may be sometimes false when it's supposed to be true.