nextcloud / talk-android

📱😀 Video & audio calls through Nextcloud on Android
Other
565 stars 249 forks source link

Add permanent hint when battery optimization is not ignored #4476

Open mahibi opened 3 days ago

mahibi commented 3 days ago

Also add an option to not show the hint, when user doesn't want to ignore battery optimization.

🖼️ Screenshots

ignore battery optimization hint ignore battery optimization dialog Option to hide the hint
Screenshot_20231108_120404 geaendert Screenshot_20231108_120547 geaendert Screenshot_20231108_120635 geaendert

🏁 Checklist

mahibi commented 3 days ago

/backport to stable-20.0

mahibi commented 17 hours ago

Should it say "not disabled" or "not ignored"? I think the warning should say disabled?

i will change the warning so it will summarize if anything is wrong with notifications, not only battery optimization. So it will include if notification are disabled in general or if notification app is not installed on server.. So the wording of the hint will be different in the end.

nickvergessen commented 4 hours ago

Can you update the screenshots?

github-actions[bot] commented 4 hours ago

APK file: https://www.kaminsky.me/nc-dev/android-artifacts/4476-talk.apk

qrcode

To test this change/fix you can simply download above APK file and install and test it in parallel to your existing Nextcloud Talk app.

github-actions[bot] commented 4 hours ago

Codacy

Lint

TypemasterPR
Warnings94158
Errors13276

SpotBugs

CategoryBaseNew
Bad practice66
Correctness1616
Dodgy code7171
Internationalization33
Malicious code vulnerability33
Performance44
Security11
Total104104

Lint increased!