Canceling screenshare OS dialog crashes app on Wayland (Ubuntu 24)

nickvergessen commented 1 week ago

How to use GitHub

Please use the 👍 reaction to show that you are affected by the same issue.
Please don't comment if you have no relevant information to add. It's just extra noise for everyone subscribed to this issue.
Subscribe to receive notifications on status change and new comments.

Follow up to #882

Steps to reproduce

Click on "Share screen"
In the operating system dialog press cancel/abort

Expected behaviour

You are back on the call screen

Actual behaviour

Client crashes 💥

Vue Devtools extension is installed
[3:1115/092440.055241:ERROR:bus.cc(571)] Failed to get the ownership of org.mpris.MediaPlayer2.chromium.instance3: org.freedesktop.DBus.Error.ServiceUnknown
[3:1115/092443.399944:ERROR:screencast_portal.cc(367)] Failed to start the screen cast session.
[3:1115/092443.399967:ERROR:base_capturer_pipewire.cc(81)] ScreenCastPortal failed: 2
Error occurred in handler for 'app:getDesktopCapturerSources': Failed to get sources.
/app/bin/electron-wrapper: Zeile 3:     3 Speicherzugriffsfehler  (Speicherabzug geschrieben) zypak-wrapper "Nextcloud Talk" "$@"

After wrapping that code with a catch it still crashes:

Vue Devtools extension is installed
[3:1115/094055.584728:ERROR:screencast_portal.cc(367)] Failed to start the screen cast session.
[3:1115/094055.584754:ERROR:base_capturer_pipewire.cc(81)] ScreenCastPortal failed: 2
Getting desktop sources failed Failed to get sources.
/app/bin/electron-wrapper: Zeile 3:     3 Speicherzugriffsfehler  (Speicherabzug geschrieben) zypak-wrapper "Nextcloud Talk" "$@"

Desktop client

Talk Desktop client version: v1.0.0-rc1

Operating system: Ubuntu

Operating system version: Ubuntu 24.04 Gnome Wayland

Microphone available: yes

Camera available: yes

Fuseteam commented 5 days ago

it also appears to happen when pressing escape rather than just clicking cancel/abort I believe it happens when pressing escape during a call altogether but more testing might be needed to verify that

nickvergessen commented 5 days ago

If it's not screenshare, but always, please create a new issue. The stacktrace of the crash here mentions specifically the screenshare function.

Fuseteam commented 4 days ago

i will verify and do that

nextcloud / talk-desktop