search

nextcloud / talk-ios

📱😀 Video & audio calls through Nextcloud on iOS
GNU General Public License v3.0
151 stars 91 forks source link

fixed SettingsViewController not updating after clearing caches #1851

Closed DanielStandfest closed 3 weeks ago

DanielStandfest commented 4 weeks ago

Fixes #1791

@SystemKeeper

SystemKeeper commented 4 weeks ago

Hey, thanks again for this PR! I actually worked on that as well in this PR https://github.com/nextcloud/talk-ios/pull/1849. But I missed the completion block for the disk cache, which is nice. So I'll remove that commit from the PR and we can go ahead with yours :)

The only thing I am wondering: Did you see any threading issues? Everything should be done on the main thread already, the completion block for example is explicitly dispatched to main already: https://github.com/SDWebImage/SDWebImage/blob/780aa6db621b7d195c31bab4d483879c1290d278/SDWebImage/Core/SDImageCache.m#L822-L831

That's the only thing I am wondering right now (and is a bit nit-picky 😉).

DanielStandfest commented 4 weeks ago

Hi, thank you for your review, Marcel. Funny that we worked on the same issue at (nearly) the same time.

No problem with being nit-picky, I am eager to learn! You are right and it seems that there are no threading issues after removing the dispatchqueue-main thread block.

I removed these parts now :)

SystemKeeper commented 3 weeks ago

/backport to stable20

github-actions[bot] commented 2 weeks ago

Hello there, Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

(If you believe you should not receive this message, you can add yourself to the blocklist.)