search

nextcloud / talk_matterbridge

This app brings the Matterbridge binary to your server to connect Nextcloud Talk with other chat services
https://apps.nextcloud.com/apps/talk_matterbridge
GNU Affero General Public License v3.0
39 stars 7 forks source link

Impersonation instead of sending messages as bot with prefix #13

Open rfc2822 opened 4 years ago

rfc2822 commented 4 years ago

First of all: the new bridge function is really awesome!! I have successfully tested it with XMPP. Connecting to Nextcloud Talk with my XMPP clients is my big vision :smile:

For daily routine, I think it would be helpful if messages in Nextcloud Talk wouldn't appear as from the bridge bot and prefixed with "protocol ", but as from the user itself (if such a mapping exists).

This would also allow to reply to the correct user instead of the bot.

Possible solution: If a user has configured their XMPP id (JID) in their personal talk_matterbridge settings, XMPP messages from this JID shouldn't be posted from the bot with "xmpp jid@example.com" prefix, but from the specific user without any prefix.

Possible security implication: If someone enters the JID of someone else, it would be possible to impersonate the other user in the chat. So maybe the JID should be verified; or the mapping could be set system-wide by admin for the beginning?

gary-kim commented 3 years ago

Work is currently going on for this here: https://github.com/nextcloud/spreed/pull/5667 Oh whoops, you meant on the sending side. That would be a change in matterbridge, not our implementation of it.