search

nextcloud / tasks

:white_check_mark: Tasks app for Nextcloud
https://apps.nextcloud.com/apps/tasks
GNU Affero General Public License v3.0
575 stars 100 forks source link

[Feature Request] Comments #109

Open alantygel opened 7 years ago

alantygel commented 7 years ago

Hi there,

I'm looking forward to be able to have comments on a task. When several users are sharing a calendar, and its associated tasks, I would like these users to be able to make comments over it (identified, and dated).

Is this functionality on the roadmap? Any hints on how to implement it?

best, alan

raimund-schluessler commented 7 years ago

This is certainly a nice improvement. Best would be to have it integrated the Nextcloud comment feature. I cannot tell, when this will be implemented, since for this to make sense, we would first need to implement the ability to share task lists with other users directly from Tasks.

alantygel commented 7 years ago

Great, thanks for the answer.

since for this to make sense, we would first need to implement the ability to share task lists with other users directly from Tasks.

As far as I understand, tasks associated to a calendar can already be shared (when the calendar is shared). In this case, comments already make sense. Right?

Together with some colleagues - @dtygel and @viniciuscb, we are considering contributing to the project in this sense. We noticed that there are some comments on the code regarding this issue (https://github.com/nextcloud/tasks/blob/378d68f763f1394bf08ea2b722d2c97d6a1b1012/templates/part.details.php#L139).

If possible, please leave here some considerations you may have about it.

best, alan

raimund-schluessler commented 7 years ago

Together with some colleagues - @dtygel and @viniciuscb, we are considering contributing to the project in this sense.

Great to hear, contributions are always welcome!

As far as I understand, tasks associated to a calendar can already be shared (when the calendar is shared). In this case, comments already make sense. Right?

Yes, that's right. If you have the Calendar app enabled, you can share calendars with other users and in case these calendars have tasks, you will see them in the Tasks app. In this case, having comments is definitively useful.

We noticed that there are some comments on the code regarding this issue

Right. Comments were implemented in an earlier version, but were not reimplemented after the move to the Nextcloud internal CalDAV server, since there was always some more important aspect of the app to work on.

As for the frontend, I would put the comments at the same place they were before in https://github.com/nextcloud/tasks/blob/378d68f763f1394bf08ea2b722d2c97d6a1b1012/templates/part.details.php#L139 but use a styling similar to the one in the files app screenshot-2017-9-7 dateien - nextcloud

Regarding the backend, I would implement it differently that it used to be. Before, I stored the comments in the ics entry, which required handling the userID and commentID manually. The benefit was, that every standard CalDAV client would have been able to see the comments, but none of the clients I am aware used to do that. Also, this was quite errorprone and is not possible at all anymore, since the CalDAV server of core is used now. Now, I think, the comments app in server which is used for the comments on a file or folder, should be used here as well: https://github.com/nextcloud/server/tree/master/apps/comments. I haven't had a look how it works yet, but it should be possible to use this app for the comments on tasks and events.

alantygel commented 7 years ago

Danke schön, Raimund!

We'll start evaluating the code here, and we'll get in touch as soon as we have some advances here.

marcusitpro commented 6 years ago

Dear, Any progess on the proposed solution? I'd be extra grateful for that appeal. It's a great use for everyone.

dtygel commented 6 years ago

@marcusitpro yes, we have a working solution! We'll create a PR very soon.

AlekseyFR commented 6 years ago

Up Dear, Any progess on the proposed solution? I'd be extra grateful for that appeal. It's a great use for everyone.

ghost commented 5 years ago

Any updates? I'm also interested in this.

ghost commented 5 years ago

@dtygel What happened with the PR? Approaching 2 years now.

itkfm commented 4 years ago

Currently using the label-less description/comment/whatsoever box for this. It works to some extent, but it doesn't really do the job. Quite a pity there's no better solution…

theorosendorf commented 3 weeks ago

Many would consider discussing with colleagues on individual tasks one of the most basic requirements of a task app. Is this feature on the horizon?