search

nextcloud / tasks

:white_check_mark: Tasks app for Nextcloud
https://apps.nextcloud.com/apps/tasks
GNU Affero General Public License v3.0
575 stars 100 forks source link

Enable checks for master branch #508

Closed raimund-schluessler closed 5 years ago

raimund-schluessler commented 5 years ago

@MorrisJobke Could you check whether it is possible to enable checks like Codecov an Travis on the master branch, like it is in the Contacts repo for example? There you see multiple checks if you click on the checks arrow.

Screenshot-2019-7-17 nextcloud contacts

Also, the Codecov badge does not show anything on the Tasks repo? Do you have an idea why?

MorrisJobke commented 5 years ago

Usually there is nothing to do from my side, because it is only a config of Travis/Codecov/etc ... there you typically can exclude some branches, that should not run the CI jobs. I can't see this for codecov for example here.

Also it shows up for the ones that were checked in the PR itself:

Bildschirmfoto 2019-07-17 um 11 35 56

For the directly pushed ones I found out that there is indeed a setting inside the Travis page and I enabled it.

raimund-schluessler commented 5 years ago

@MorrisJobke Thanks for taking care of this. Could you maybe also check whether you could enable Codecov for the Tasks repository? I send an request to the Nextcloud organization for enabling the Github app.

MorrisJobke commented 5 years ago

@MorrisJobke Thanks for taking care of this. Could you maybe also check whether you could enable Codecov for the Tasks repository? I send an request to the Nextcloud organization for enabling the Github app.

Codecov is just where the data is dumped. Most likely from travis builds and then it should also show up

raimund-schluessler commented 5 years ago

Travis is configured for codecov already and uploading reports works. But it would be nice if codecov reports as a check like Travis and Scrutinizer (and as it is in the contacts repo).

MorrisJobke commented 5 years ago

Travis is configured for codecov already and uploading reports works. But it would be nice if codecov reports as a check like Travis and Scrutinizer (and as it is in the contacts repo).

Ah ... I just noticed that this is not added here.

MorrisJobke commented 5 years ago

Enabled.