Sync endpoint always sets up the file sytem

[juliusknorr]

The sync endpoint actually always sets up the filesystem for the user due to the current way we check if the file has changed outside:

We mainly need to obtain the mtime and etag of the file to detect if it was changed or if it should be autosaved and ideally we only need to go to the filesystem layer in those cases. However I currently don't see a proper way of only obtaining those details without querying the filecache directly, which we could do since we have the file id. Alternatively we can probably introduce our own state handling by hooking into the postWrite hook and basically marking text documents as changed outside then.

@rullzer Do you see any other way? I'd probably prefer just querying the filecache directly from a implementation perspective but the hook feels a bit cleaner.

[rullzer]

So the hook would be triggering an event that the text app can react on to obtain the info right? It indeed feels cleaner.

The problem I see is that you do a lot of potential work if there are files being changed and you have to somehow react to them.

• You need to query if the file is currently actively open
• Then store it somewhere

While text is presumably only running on a very limited set of files.

We could of course just only do this for systems with a proper cache setup?

So we store a list of filid => mtime in the cache. Then if a write event happens we check the cache for the fileid if it is not there we ignore if it is we update the mtime?

[Raudius]

From what I can tell this is still relevant \OCA\Text\Service\DocumentService::getFileById, so will leave this open for now

[juliusknorr]

Kind of related to #1042 as well