search

nextcloud / text

📑 Collaborative document editing using Markdown
GNU Affero General Public License v3.0
555 stars 91 forks source link

l10n: Author colors #1545

Closed Valdnet closed 1 month ago

Valdnet commented 3 years ago

Could you describe this feature in more detail: https://github.com/nextcloud/text/blob/38e37b234170c473e784f567fa3e70d4fe5004f5/src/components/SessionList.vue#L67-L69

Function description:

In my opinion it is a bit vague.

As for the author colors only visible when editing the file, why isn't it a description like this:

juliusknorr commented 3 years ago

I think the current version makes it more clear that the author colors are not persisted, but I also agree that the wording isn't the best there yet.

Author colors are only shown when editing the document.

Doesn't make it clearer in my oppinion. The main point here is that if all users close the document the author information will be gone and if the file is reopened a fresh tracking of authors will start.

cc @jancborchardt

juliusknorr commented 2 years ago

🏓 @jancborchardt @nimishavijay

marcelklehr commented 2 years ago

How about

Author colors will be lost after everyone has closed the document

jancborchardt commented 2 years ago

Great suggestion @marcelklehr, let’s do it like that! :)

jancborchardt commented 2 years ago

Maybe small adjustment: "cleared" instead of "lost" since "lost" sounds a bit dangerous.

max-nextcloud commented 1 year ago

We still need to bring author colors back after the y.js rework. So I'm removing this from the list of good first issues as it's currently blocked.

juliusknorr commented 1 month ago

Let's close this as currently we don't have author colors as a feature