search

nextcloud / text

📑 Collaborative document editing using Markdown
GNU Affero General Public License v3.0
539 stars 87 forks source link

Migrate icons to vue-material-design-icons #2345

Closed juliushaertl closed 2 years ago

juliushaertl commented 2 years ago

Nextcloud 25 will drop support for SCSS and the icon generation that is currently in use in text (ref https://github.com/nextcloud/server/issues/32060)

We need to make sure all icons are replaced with inline SVGs through vue-material-design-icons so they can then also properly adapt to the dark mode which is currently broken on master.

Other than that existing scss code form css/ should rather be moved to src/ and the corresponding components.

juliushaertl commented 2 years ago

More urgent now that the icon classes are no longer generated with https://github.com/nextcloud/server/pull/32326

I think to approach that we should basically expose an icon component from vue-material-design-icons in src/mixings/menubar.jsand make sure to use that instead of the icon class insrc/components/MenuBar.vue`