nextcloud / text

📑 Collaborative document editing using Markdown
GNU Affero General Public License v3.0
528 stars 85 forks source link

Cropped menu bar on small screens #3368

Open XueSheng-GIT opened 1 year ago

XueSheng-GIT commented 1 year ago

Describe the bug On small screens or mobile devices the menu bar is sometimes cropped (icons not visible). It seems that this issue can be forced if the screen size is reduced quite fast. On my mobile devices this issue appears from time to time if text files are opened (issue cannot be forced).

To Reproduce Steps to reproduce the behaviour:

  1. Open a markdown (text) file
  2. Resize (reduce) the window quite fast (to force this issue)

Expected behavior All icons of menu bar should be accessible (at least through the "3-dots" menu), instead of hiding completely somehow.

Screenshots Cropped menu bar.webm

Client details:

Server details **Text app version:** 3.6.0 **Operating system:** Ubuntu 20.04 **Web server:** apache2 (2.4.54) **Database:** mariadb (Ver 15.1 Distrib 10.3.34-MariaDB) **PHP version:** 7.4.32 **Nextcloud version:** 25.0.1
susnux commented 1 year ago

For those who are interested why this happens:

This happens because some menu bar entries should be always visible (those with unset priority or priority === undefined here https://github.com/nextcloud/text/blob/master/src/components/Menu/entries.js ). They will not move into the overflow menu even when the screen is too small.

It is currently not possible allow those actions to be moved into the overflow menu as they provide submenus. And submenus do not work within the overflow menu (NcActions do not work within NcActions).