nextcloud / text

📑 Collaborative document editing using Markdown
GNU Affero General Public License v3.0
545 stars 87 forks source link

Unable to toggle quote on checkbox items #3389

Open juliushaertl opened 1 year ago

juliushaertl commented 1 year ago

The following doesn't seem to work as reported by @jancborchardt in a call:

jancborchardt commented 1 year ago

Actually haven't tried clicking the blockquote element, but I tried doing it via keyboard. It's not possible to insert the quote then.

Maybe it's also not such a big problem if it works via the toolbar – I ended up inserting the quote in the line above and removing the linebreak.

juliushaertl commented 1 year ago

@jancborchardt To clarify this is what you tried to achieve, right?

  • [ ] Checkbox in block quote?

The other way would not be possible as list items cannot contain block elements in GFM

juliushaertl commented 1 year ago

@mejo- Also kind of related to #2291 I think there might be different expectations on what should happen if you have the cursor in a list item and click block quote. Without considering markdown limitations it could mean:

  1. Change from list to blockquote
  2. Wrap the list in a block quote
  3. Add a blockquote within the list item

@nextcloud/designers What would be your take on this? From my perspective 1. might be the most generic solution for any block elements to just switch between them.

szaimen commented 1 year ago

I'd say 3 would be expected from my side.

juliushaertl commented 1 year ago

Ok, 3 is not possible though on markdown ;)

nimishavijay commented 1 year ago

We could go with 2, it seems easy to remove an unwanted blockquote or list item by using the toolbar rather than not being able to add a list item within a blockquote because always changes the formatting :)

szaimen commented 1 year ago

Yeah, I would then choose 2 as well