nextcloud / text

📑 Collaborative document editing using Markdown
GNU Affero General Public License v3.0
556 stars 92 forks source link

make it possible to configure supported filenames for rich workspace #5446

Open landryb opened 8 months ago

landryb commented 8 months ago

Is your feature request related to a problem? Please describe. the rich workspace feature is awesome, but the list of filename patterns that trigger it is:

we use nextcloud in a french context, with no-so-savvy users, and so far provide them readonly shares with a _LISEZMOI.md file (LISEZMOI=README in french) because they:

we were previously using files_markdown/files_texteditor so that they had the markdown rendered when clicking on the files. Since we're switching to the text app, i'm planning to enable the awesome rich workspace feature, because that way the markdown would be displayed straight away when landing in the share. .. but the name doesn't match the patterns, and the patterns are hardcoded.

Describe the solution you'd like it would be great to be able to override the default list via an occ app:config toggle

Describe alternatives you've considered mass-renaming all _LISEZMOI.md files, which could lead to user confusion since we've explained them that this file was supposed to be here. and they might not understand README.md either.

landryb commented 8 months ago

after looking at the code thinking how hard would it be ?, i've now spotted https://github.com/nextcloud/text/blob/main/lib/Service/WorkspaceService.php#L40 which, via https://github.com/nextcloud/text/blob/main/l10n/fr.js#L20 allows a file named Lisez moi.md to be automatically rendered in the rich workspace.

That will probably suit my usecase, but having it configurable could be a nice addition.. adding the config value to self::SUPPORTED_STATIC_FILENAMES ?