nextcloud / text

📑 Collaborative document editing using Markdown
GNU Affero General Public License v3.0
529 stars 85 forks source link

Ctrl+Backspace inserts new item into unordered list with Firefox #5839

Open PatrickJosh opened 1 month ago

PatrickJosh commented 1 month ago

Describe the bug Since the update to Nextcloud 29, pressing Ctrl+Backspace in an unordered list behaves weirdly. When pressing it with more than one word left in the current line/item, it behaves normally and deletes the word before the cursor. However, when pressing it with only one word left in the current line, it inserts a new item below and focusses this item. However, it only happens with Firefox, not with Chromium; there, it behaves normally. Have a look at the following video to get a better understanding:

https://github.com/nextcloud/text/assets/32456639/3c010557-5768-4067-8b5e-3ccc27e177ab

In the video, I only press Ctrl+Backspace, nothing else.

To Reproduce Steps to reproduce the behavior:

  1. Have an unordered list
  2. Press Ctrl+Backspace with only one item left in the line

Expected behavior The last remaining word is deleted as well.

Screenshots See video above.

Server details:

Client details:

Logs #### Nextcloud log (data/nextcloud.log) Probably not necessary; if it is, just tell me. #### Browser log [console-export-2024-5-27_18-3-41.txt](https://github.com/nextcloud/text/files/15457899/console-export-2024-5-27_18-3-41.txt)
mejo- commented 1 month ago

I can reproduce this on latest Text main branch, but not in a Tiptap sandbox.

juliushaertl commented 1 week ago

From #5962 :

Let me put some references here as well: https://github.com/ProseMirror/prosemirror-view/blob/master/CHANGELOG.md#1337-2024-05-31 https://github.com/ProseMirror/prosemirror-view/commit/8c9a7d25021ce8e99d03a63c7fb7033a524fd4db

Was bumped in tiptap upstream for the upcoming 2.5.0 release with https://github.com/ueberdosis/tiptap/commit/747985b3a7617e35702a6dab4ecc87c76610204b