nextcloud / text

📑 Collaborative document editing using Markdown
GNU Affero General Public License v3.0
528 stars 85 forks source link

fix: Ignore pushes of update steps for read only sessions #5895

Closed juliushaertl closed 2 weeks ago

juliushaertl commented 2 weeks ago

My suggestion for now would be to block any update steps for read only sessions according to what is described in the y.js protocol docs.

https://github.com/yjs/y-protocols/blob/master/PROTOCOL.md#handling-read-only-users

Ideally we'd of course also prevent sending those in the frontend code, but for now this seems the most reasonable quick fix.

juliushaertl commented 2 weeks ago

/backport to stable29

juliushaertl commented 2 weeks ago

/backport to stable28