search

nextcloud / text

📑 Collaborative document editing using Markdown
GNU Affero General Public License v3.0
552 stars 91 forks source link

Title bar uses wrong "dark" theme even in light mode #6386

Closed arnowelzel closed 1 month ago

arnowelzel commented 1 month ago

Describe the bug When Nextcloud is using a "light" theme, the text editor uses a "dark" theme title bar which makes the elements very hard to see due to the light grey color.

In the HTML source you can also see the wrong theme data-theme-dark used:

<div data-v-1d602fb0="" data-theme-dark="" class="modal-header">

This would be the correct code:

<div data-v-1d602fb0="" data-theme-light="" class="modal-header">

To Reproduce Steps to reproduce the behavior:

  1. Make sure Nextcloud is using a "light" theme.
  2. Open or create a text document.
  3. See the title bar in light grey color instead of the expected dark color.

Expected behavior The title bar uses the correct theme.

Screenshots

image

Server details:

Client details:

Rahul-2006 commented 1 month ago

Hi @arnowelzel If the theme is only the concern , i can adjust it and it can help me in growing my open source journey

arnowelzel commented 1 month ago

Hi @arnowelzel If the theme is only the concern , i can adjust it and it can help me in growing my open source journey

Yes, only the attribute for the theme should match the current Nextcloud theme. Thanks for your help!

Rahul-2006 commented 1 month ago

So can i get it assigned ?

arnowelzel commented 1 month ago

I am not a team member of Nextcloud, so I can not assign you. Maybe they can help. However you can always start working on that anyway and provide a pull request with your changes.

Rahul-2006 commented 1 month ago

Ok I will start working on this then...

mejo- commented 1 month ago

@Rahul-2006, before you start working on this, we already have a fix ready sorry. It was a rather complex fix in other components: https://github.com/nextcloud-libraries/nextcloud-vue/pull/6083 and https://github.com/nextcloud/viewer/pull/2528

Thanks still for your interest in contributing. Feel free to pick another issue that you want to work on :blush:

Rahul-2006 commented 1 month ago

Ok!! Thank you