search

nextcloud / translate

A Machine translation provider using Opus models by University of Helsinki running locally on CPU
11 stars 1 forks source link

fix(Provider): Don't return empty string when failed to translate #8

Closed nickvergessen closed 1 year ago

nickvergessen commented 1 year ago

Steps

  1. Download de-en only
  2. Send a translation request for en-es

Before

😕 OK 200 ?

curl -k 'https://nextcloud27.local/ocs/v2.php/translation/translate?text=calculate&fromLanguage=en&toLanguage=es&format=json' -u admin:admin -H 'OCS-APIRequest: true' -v -X POST
{"ocs":{"meta":{"status":"ok","statuscode":200,"message":"OK"},"data":{"text":""}}}

After

😿 Error 500 ? (Probably should be a 400 or something, but that needs changing in server)

curl -k 'https://nextcloud27.local/ocs/v2.php/translation/translate?text=calculate&fromLanguage=en&toLanguage=es&format=json' -u admin:admin -H 'OCS-APIRequest: true' -v -X POST
{"ocs":{"meta":{"status":"ok","statuscode":200,"message":"OK"},"data":{"message":"Unable to translate","0":500}}}