search

nextcloud / twofactor_gateway

🔑 Second factor provider using an external messaging gateway (SMS, Telegram, Signal)
GNU Affero General Public License v3.0
110 stars 63 forks source link

RFE: use name from theming in authentication code message #274

Open putt1ck opened 5 years ago

putt1ck commented 5 years ago

In a world of phishers, it seems sensible to ensure the messages sent by a system are not generic, especially when we train people to be suspicious of messages. So if we can use the "name" element from the NC theming in the message sent to the user this increases its trust level. So in the Signal message it currently reads "123654 is your Nextcloud authentication code" and with this enhancement it would read "123654 is your My Site Name authentication code"

ChristophWurst commented 5 years ago

Yes! I've briefly mentioned this at https://github.com/nextcloud/twofactor_gateway/pull/253#discussion_r308589512 but we should indeed do this!

The only concern right now is that theming isn't properly exposed via a public API in the Nextcloud server. But I'll open a ticket for it if it doesn't already exist.

ChristophWurst commented 5 years ago

https://github.com/nextcloud/server/issues/15815 was the ticket