search

nextcloud / twofactor_gateway

🔑 Second factor provider using an external messaging gateway (SMS, Telegram, Signal)
GNU Affero General Public License v3.0
109 stars 62 forks source link

Guzzle version conflicts with bookmark plugin #349

Open crami opened 4 years ago

crami commented 4 years ago

looks like the guzzle version shipped is older then the one used by the bookmarks plugin (1.6.1). This leads to an error that bookmark syncing does not work. "Call to undefined function GuzzleHttp\_idn_uri_convert()"

ChristophWurst commented 4 years ago

Known problem. See https://github.com/nextcloud/twofactor_gateway/pull/316#issuecomment-576351190

With https://github.com/coenjacobs/mozart/issues/11#issuecomment-611746985 we might be able to progress without the change in the upstream ovh lib.

ChristophWurst commented 4 years ago

With coenjacobs/mozart#11 (comment) we might be able to progress without the change in the upstream ovh lib.

For details see https://blog.wuc.me/2020/05/13/rock-me-amadeus-php-dependency-hell.html

marcelklehr commented 4 years ago

Just for reference: The conflict is not with the bookmarks app itself, but rather with nextcloud core. Bookmarks only fails as a result of that.

OCA\Bookmarks\Http\Client calls OC\Http\Client\Client in nextcloud core which calls GuzzleHttp\Client, but that gets loaded from var/www/html/apps/twofactor_gateway/vendor/guzzlehttp/guzzle/src/Client.php.