search

nextcloud / twofactor_totp

🔑 Second factor TOTP (RFC 6238) provider for Nextcloud
https://apps.nextcloud.com/apps/twofactor_totp
GNU Affero General Public License v3.0
292 stars 56 forks source link

Inconsistent size of 2FA-type icons #493

Open MariusBluem opened 5 years ago

MariusBluem commented 5 years ago

Do not know wheter this is an issue with this app, the server or the notifications-2FA. 🤔 @ChristophWurst

1

ChristophWurst commented 5 years ago

Good point. Is this a specific browser or does it happen with all?

ChristophWurst commented 5 years ago

cc @nickvergessen @rullzer for the notifications app

ChristophWurst commented 5 years ago

bildschirmfoto von 2019-03-07 09-51-16 on my dev instance, without the notifications provider

nickvergessen commented 5 years ago

Which size are you using? Is it documented?

nickvergessen commented 5 years ago

Should add the recommended size to this block: https://github.com/nextcloud/server/blob/45cf2eef56549f4c360609f82aed8b38e7bb0335/lib/public/Authentication/TwoFactorAuth/IProvidesIcons.php#L37-L53

Or try to fix it with CSS

MariusBluem commented 5 years ago

Tested with Safari and Microsoft Edge but I think it is happening for all.

rullzer commented 5 years ago

I saw this as well on my private instance. We do not provide an icon I think for the notifications app. So I think the default is just used...

rullzer commented 5 years ago

Mmm I can't trigger it anymore.

ChristophWurst commented 5 years ago

Should add the recommended size to this block

I think we should have a required minimum + some css that limit the max size

ChristophWurst commented 5 years ago

Mmm I can't trigger it anymore.

Did we fix it for 16 maybe?

rullzer commented 5 years ago

Did we fix it for 16 maybe?

Also can't trigger it on 15 ;)

ChristophWurst commented 5 years ago

@MariusBluem is that a specific setup you were testing on?

MariusBluem commented 5 years ago

It was our company cloud :)