search

nextcloud / twofactor_u2f

🔑 U2F second factor provider for Nextcloud
https://apps.nextcloud.com/apps/twofactor_u2f
GNU Affero General Public License v3.0
112 stars 27 forks source link

Support for NC24 and PHP8.1 #1003

Closed nursoda closed 2 years ago

nursoda commented 2 years ago

On my NC24b3 instance running on Arch linux with PHP 8.1, upon occ app:enable twofactor_u2f and despite of adding twofactor_u2f to the app_install_overwrite array in config/config.php I cannot enable the app since this requirement cannot(?) be overruled:

cannot be installed because the following dependencies are not fulfilled:
PHP with a version lower than 8.0 is required.

This is due to appinfo/info.xml reading

<php min-version="7.3" max-version="8.0"/>
<nextcloud min-version="20" max-version="23"/>

Please change appinfo/info.xml to

<php min-version="7.3" max-version="8.1"/>
<nextcloud min-version="21" max-version="24"/>

according to the most recent app upgrade guide.

I'm not doing a PR since I cannot check or tell whether anything else must be changed (although I don't expect it).

Manually changing appinfo/info.xml and enabling the app works fine for me with NC24 and PHP8.1.

ChristophWurst commented 2 years ago

Considering https://github.com/nextcloud/twofactor_u2f/issues/947 I don't know if we even do another release. I'll have a look.

Showfom commented 2 years ago

Please support NC 24, we are waiting for update.

Thanks for your great app.

nursoda commented 2 years ago

I switched to twofactor_webauthn, works for me.

@ChristophWurst you should decide and tell people whether to expect a release for NC24 or not.

gituser789 commented 2 years ago

Same issue here. Can we update, or should we switch to twofactor_webauthn?

nextcloud

ChristophWurst commented 2 years ago

You should switch

ChristophWurst commented 2 years ago

We are phasing out this app. There will be no more features or support for newer Nextcloud/PHP.

gituser789 commented 2 years ago

ok, thanks!