nextcloud / twofactor_u2f

🔑 U2F second factor provider for Nextcloud
https://apps.nextcloud.com/apps/twofactor_u2f
GNU Affero General Public License v3.0
112 stars 26 forks source link

U2F and Passwordless Authentication with same key Issue (NC 19) #756

Open hockey6611 opened 4 years ago

hockey6611 commented 4 years ago

Feature Request

Add logic to identify when passwordless authentication is enabled with same key as U2F. Add features around this logic:

Summary

I noted in a test installation of Nextcloud 19 that I am able to set up passwordless authentication and U2F authentication with the same key. I think that this will technically allow bypass of MFA, and thus reduce security.

In my usecase, my nextcloud instance is not exposed to the internet directly, so I would like the option to use both passwordless and U2F as an MFA option (along with TOTP, etc.) However, this should not be the default. I would imagine this to be disabled by default and a checkbox for the administratior to allow the same key to be used for passwordless and U2F.

ChristophWurst commented 4 years ago

This is a tricky one, we'd need a way for the app to communicate with Nextcloud's passwordless auth and vice versa to exchange this information. But I'll think about it.

Thanks for the feedback :v:

hockey6611 commented 4 years ago

Thank you for looking into it, and thank you for the work on this app. I am not sure on the hooks nextcloud core allows too see the u2f key used for passwordless, I can definitely see this being tricky. I am not developer, only a user of nextcloud. Would a new issue in the nextcloud core be necessary?

ChristophWurst commented 4 years ago

As I'm a developer of both system it's fine to have this ticket here :)