search

nextcloud / unsplash

📸🔀☁️ Random Nextcloud log in background from Unsplash
https://apps.nextcloud.com/apps/unsplash
GNU Affero General Public License v3.0
92 stars 23 forks source link

Splash 2.0.0 Blocks Nextcloud #106

Closed tigernero79 closed 1 year ago

tigernero79 commented 1 year ago

use GitHub reactions 👍 to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug: After updating splash to version 2.0.0 on armhf debian 10 Buster raspberry the plugin crashes nextcloud 24.0.5. which does not happen on debian 11 arm64 raspberry system

To Reproduce: Steps to reproduce the behavior:

Expected behavior:

Screenshots: Senza titolo

Server:

Additional Information:

skjnldsv commented 1 year ago

Please share your nextcloud log error with us. Search for the specified request ID in your screenshot Do not share the entire file with us :)

newhinton commented 1 year ago

Yes, only the log will help me debug this. My own instance updated fine, but that has nothing to say.

tigernero79 commented 1 year ago

{"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"user_saml","method":"GET","url":"/index.php/apps/files/","message":"/appinfo/app.php is deprecated, use \\OCP\\AppFramework\\Bootstrap\\IBoots${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"encryption","method":"GET","url":"/index.php/apps/files/","message":"/appinfo/app.php is deprecated, use \\OCP\\AppFramework\\Bootstrap\\IBoot${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"music","method":"GET","url":"/index.php/apps/files/","message":"/appinfo/app.php is deprecated, use \\OCP\\AppFramework\\Bootstrap\\IBootstrap${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"socialsharing_diaspora","method":"GET","url":"/index.php/apps/files/","message":"/appinfo/app.php is deprecated, use \\OCP\\AppFramework\\Boot${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"socialsharing_email","method":"GET","url":"/index.php/apps/files/","message":"/appinfo/app.php is deprecated, use \\OCP\\AppFramework\\Bootstr${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"socialsharing_facebook","method":"GET","url":"/index.php/apps/files/","message":"/appinfo/app.php is deprecated, use \\OCP\\AppFramework\\Boot${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"socialsharing_twitter","method":"GET","url":"/index.php/apps/files/","message":"/appinfo/app.php is deprecated, use \\OCP\\AppFramework\\Boots${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":1,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"no app in context","method":"GET","url":"/index.php/apps/files/","message":"Deprecated event type for OCA\\Files::loadAdditionalScripts: Symfo${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"Flow activation: rules were requested for operation Blocca accesso a ${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"No flow configurations is going to run Blocca accesso a un file","use${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":1,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"no app in context","method":"GET","url":"/index.php/apps/files/","message":"Deprecated event type for OCA\\Files::loadAdditionalScripts: Symfo${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"Flow activation: rules were requested for operation Blocca accesso a ${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"No flow configurations is going to run Blocca accesso a un file","use${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":1,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"no app in context","method":"GET","url":"/index.php/apps/files/","message":"Deprecated event type for OCA\\Files::loadAdditionalScripts: Symfo${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"Flow activation: rules were requested for operation Blocca accesso a ${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"No flow configurations is going to run Blocca accesso a un file","use${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":1,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"no app in context","method":"GET","url":"/index.php/apps/files/","message":"Deprecated event type for OCA\\Files::loadAdditionalScripts: Symfo${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"Flow activation: rules were requested for operation Blocca accesso a ${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"No flow configurations is going to run Blocca accesso a un file","use${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":1,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"no app in context","method":"GET","url":"/index.php/apps/files/","message":"Deprecated event type for OCA\\Files::loadAdditionalScripts: Symfo${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"Flow activation: rules were requested for operation Blocca accesso a ${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"No flow configurations is going to run Blocca accesso a un file","use${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":1,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"no app in context","method":"GET","url":"/index.php/apps/files/","message":"Deprecated event type for OCA\\Files::loadAdditionalScripts: Symfo${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"Flow activation: rules were requested for operation Blocca accesso a ${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"No flow configurations is going to run Blocca accesso a un file","use${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":1,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"no app in context","method":"GET","url":"/index.php/apps/files/","message":"Deprecated event type for OCA\\Files::loadAdditionalScripts: Symfo${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"Flow activation: rules were requested for operation Blocca accesso a ${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":0,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"workflowengine","method":"GET","url":"/index.php/apps/files/","message":"No flow configurations is going to run Blocca accesso a un file","use${"reqId":"CSeCm3ppRIHAwyBsKxNl","level":3,"time":"2022-10-04T14:03:03+00:00","remoteAddr":"84.33.95.181","user":"Tiger","app":"index","method":"GET","url":"/index.php/apps/files/","message":"syntax error, unexpected 'string' (T_STRING), expecting function (T_FUNCTION)

newhinton commented 1 year ago

Is this the full log? It seems cut off and that parts are missing.

I need the error with the code displayed in your screenshot.

Also, next time please follow the bug-template.

tigernero79 commented 1 year ago

I am attaching you complete log file, I did regenerate error by re-enabling unsplash with error code id: CSeCm3ppRIHAwyBsKxNl

nextcloud.log

newhinton commented 1 year ago

Which php version do you use? and it seems that the nextcloud version of the error-instance is 23 not 24, i will test that now. Though on x86 not arm

newhinton commented 1 year ago

It is very likely that you are running php 7.3. I think i started using class definitions, which are available only on 7.4.

marius-wieschollek commented 1 year ago

In that case the php minimum requirement should be increased in the appinfo.xml. Also maybe the update should be removed or more people will try to upgrade to a version that does not run for them.

newhinton commented 1 year ago

In that case the php minimum requirement should be increased in the appinfo.xml. Also maybe the update should be removed or more people will try to upgrade to a version that does not run for them.

Yes i already prepared a version for that. I am currently researching if revoking is possible, can i just "redo" the release with the same tag?

Also it is not verified 100% because i dont have access to a system and i have to set one up, but it seems the most likely.

@tigernero79 Can you test something for me? On the server which does not work, can you edit the nextcloud/apps/unsplash/lib/Provider/Unsplash.php-file in line 31 and 32, removing string and bool respectively from the lines? You may need to do the same for the nextcloud/apps/unsplash/lib/ProviderHandler/Provider.php-file.

If you can't do that, thats fine, but then it will take more time for me to replicate your system ;)

marius-wieschollek commented 1 year ago

You can delete the release trough the api: https://nextcloudappstore.readthedocs.io/en/latest/restapi.html#api-delete-release

tigernero79 commented 1 year ago

unfortunately debian buster has php 7.3 in itself, I removed the words bool and string from the lines you mentioned but the error remains, I also modified the second file by deleting all the active string and bool entries but nothing @newhinton

newhinton commented 1 year ago

Ah okay, i will try to make it compatible and rerelase it. For now, please disable unsplash via occ until i release 2.0.1

newhinton commented 1 year ago

@tigernero79 I have updated the app to 2.0.1, you should be able to update the app in the upcoming hours. It is compatible with php7.3. Please report back if it is fixed for you! (You can also always use git, but you need to use the nextcloud24_providerupdate-branch, not the master-branch!)

tigernero79 commented 1 year ago

updated to unsplash 2.0.1 everything ok solved thanks for everything 😇

newhinton commented 1 year ago

Great! And Sorry for the inconvenience,