nextcloud / unsplash

πŸ“ΈπŸ”€β˜οΈ Random Nextcloud log in background from Unsplash
https://apps.nextcloud.com/apps/unsplash
GNU Affero General Public License v3.0
92 stars 23 forks source link

App not wotking after upgrade from v23 to v24 #113

Closed adripo closed 1 year ago

adripo commented 1 year ago

use GitHub reactions πŸ‘ to show that you are affected by the same issue. Please don't comment if you have no relevant information to add!

Describe the bug:

After upgrading from v23 to v24 this app stopped wotking. In the user settings the only visible part is this one

image

without any possible choice for the images.

In the system settings this is selected. Even if I enable by default no image is shown anyway.

image

To Reproduce: Steps to reproduce the behavior:

  1. Go to Settings
  2. Click on Splash
  3. See error

Expected behavior:

Be able to select where to apply background user-per-user

Server:

Additional Information: No info on system log. Is it possilbe to remove some broken settings on the db to fix the issue?

adripo commented 1 year ago

Additional logs: image

newhinton commented 1 year ago

(Nearly) All the user settings have been removed for 2.0.0.

The dashboard can be selected by the user anyway on the dashbard itself, we autodetect the default image there and replace it with the unsplash one.

The login can't be changed by the user anyway, and the header-settings are only visible to the user if they are enabled by the admin in the theming settings. (And in 25 even this is gone because there is no "header" anymore, the background is implicitly set by the user's background.)

tonytonyistony commented 1 year ago

Additional logs: image I am also getting these errors in my logs. When I check the folder path specified I get the following files.

-rw-r--r-- 1 www-data www-data  451 Dec 21 06:46 licenseUnsplash.php
-rw-r--r-- 1 www-data www-data  450 Dec 21 06:46 licenseWallhavenCC.php
-rw-r--r-- 1 www-data www-data  341 Dec 21 06:46 licenseWikimediaCommons.php

Thinking about renaming one of the to license and see what happens.

Also my splash screens are working as they should. Just getting the error logs.

EDIT: Confirmed that Im using the WallhavenCC splash screens. I made a copy of the licenseWallhavenCC.php and named it license.php. Now the errors do not exist.

newhinton commented 1 year ago

@tonytonyistony I think this is not related to this issue. i have referenced this in #114.

@adripo I assume that all questions have been cleared up, and with no further interaction i will close this ticket soon. If you have additional questions please ask!

adripo commented 1 year ago

@newhinton Thank you for the clarification. I will close the issue.