search

nextcloud / unsplash

📸🔀☁️ Random Nextcloud log in background from Unsplash
https://apps.nextcloud.com/apps/unsplash
GNU Affero General Public License v3.0
92 stars 23 forks source link

[WIP] correct errors on /unsplash/templates/settings/admin.php and improvement pt_BR translate #127

Open leolemos opened 1 year ago

leolemos commented 1 year ago

fixed error when accessing app settings "message":"include(): Failed opening .../partials/license.php'

correct pt_BR.json and pt_BR.js

create file js/user.js to prevent error when access user theme edit panel

commented out line 10 from file /templates/settings/personal.php preventing error when accessing the user's theme settings

newhinton commented 1 year ago

Can you mark this as done when it is ready to review? Thanks!

leolemos commented 1 year ago

Can you mark this as done when it is ready to review? Thanks!

hello :-)

could you help me to mark as done?

sorry but this is my 1st time using github and I don't know how to do this :-(

thanks :-)

newhinton commented 1 year ago

Can you mark this as done when it is ready to review? Thanks!

hello :-)

could you help me to mark as done?

sorry but this is my 1st time using github and I don't know how to do this :-(

thanks :-)

Sure! I just added a [WIP] to the title of this PR. However, the right way to do it is to use the draft-function, but i didn't do that.

So the next time you create a PR and want to indicate that you are not done, you can click on that: grafik

Its on the top right of this page. However, i fixed it for you.

Now to your actual PR: Frist, thanks for contributing! It is always good to see people wanting to chime in!

It seems you did two things:

  1. Updatin translations
  2. Fixing a loading issue with some partials.

Usually it is a good idea to split RP's into multiple ones if you fix different issues. Here one with the translations would be good, and another one with the fixes for the partials. However, since this is a small PR and it's your first time, i will review it how it is and merge it if i cant find anything that needs change. From a first glance it looks good, but i will need to verify the code and i cant to that at the moment. (Worst case i will do it at the upcoming nextcloud conference in a few weeks!)

Welcome to open source!